Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mixpanel + migrate to pnpm + update dependencies (incl. React 18 and Next 13) #300

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

benface
Copy link
Contributor

@benface benface commented Mar 3, 2023

No description provided.

@benface benface requested a review from a team as a code owner March 3, 2023 19:13
@github-actions
Copy link

github-actions bot commented Mar 3, 2023

diff --git a/route-lockfile.txt b/route-lockfile.txt
index 57d383f..8f8b708 100644
--- a/route-lockfile.txt
+++ b/route-lockfile.txt
@@ -40,9 +40,9 @@
 /en/404/
 /en/about/
 /en/arbitrum-faq/
-/en/mips-faqs/
 /en/billing/
 /en/cookbook/arweave/
+/en/cookbook/base-testnet/
 /en/cookbook/cosmos/
 /en/cookbook/grafting/
 /en/cookbook/migrating-a-subgraph/
@@ -64,6 +64,7 @@
 /en/glossary/
 /en/managing/deprecating-a-subgraph/
 /en/managing/transferring-subgraph-ownership/
+/en/mips-faqs/
 /en/network-transition-faq/
 /en/network/benefits/
 /en/network/curating/

Comment on lines -1 to -4
ALGOLIA_API_KEY=
ALGOLIA_APP_ID=
NPM_TOKEN=
SITE_URL=https://thegraph.com/docs
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file was redundant because we already have .env checked in the repo. It's weird but that's what Next recommends. The .env file basically serves as .env.example but with some default values (the ones that aren't secrets), and it can be duplicated into .env.local to add secrets.

Comment on lines +12 to +13
MIXPANEL_TOKEN:
process.env.ENVIRONMENT === 'production' ? 'cfeac8baf33c9b4d255f28d57f3c9148' : 'e57a9892339b2acfd02943c86b746d32',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not secrets (that token is included in the frontend bundled).

@benface benface merged commit a90a677 into main Mar 3, 2023
@benface benface deleted the benface/tracking branch March 3, 2023 19:40
This was referenced Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants